Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macro methods for ClassDef, EnumDef, AnnotationDef #14072

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Add macro methods for ClassDef, EnumDef, AnnotationDef #14072

merged 4 commits into from
Dec 13, 2023

Conversation

HertzDevil
Copy link
Contributor

Resolves part of #14059.

straight-shoota
straight-shoota approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have a suggestion for a slight refactor.

src/compiler/crystal/macros/methods.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 1.11.0 milestone Dec 12, 2023
@straight-shoota straight-shoota merged commit 6fe0ef7 into crystal-lang:master Dec 13, 2023
55 checks passed
@HertzDevil HertzDevil deleted the feature/macro-class-def branch December 14, 2023 16:38
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:macros
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota