Add Reference.pre_initialize and .unsafe_construct
#14108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Dec 17, 2023
HertzDevil
commented
Dec 17, 2023
src/primitives.cr
Outdated
| # otherwise all calls will refer to the sole instantiation in | ||
| # `Reference.class`. This is necessary when the receiver is a virtual | ||
| # metaclass type. Apparently this works even for primitives | ||
| {% @type %} |
There was a problem hiding this comment.
Not entirely sure what to do with this. A fresh compiler will break if the existing compiler's version is below 1.2.0 and the compiler itself uses .pre_initialize / .unsafe_construct on a virtual metaclass. I don't think that is very likely, but if we must do it, the only solution seems to be explicitly defining .pre_initialize in every subclass of Reference in the compiler, similar to .allocate.
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
|
@HertzDevil In case you missed it, I also left a comment on a previously resolved thread: #14108 (comment) WDYT? |
straight-shoota
approved these changes
Dec 19, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13481.
This PR references
ReferenceStoragefrom #14106 in documentation only. These methods are not defined on struct or value types, nor implemented inside the interpreter.