Change Regex::MatchData#to_s
to return matched substring
#14115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #13118
Currently,
MatchData#to_s
is the same asMatchData#inspect
, which means that it returns an object representation of the MatchData:Regex::MatchData("ys" 1:"y" 2:"s")
This is not only inconsistent with Ruby, which returns the matched substring, and most other languages, like rust's regexp crate, but also not really useful for anything besides debugging (which is exactly where you should use inspect over to_s).
Much more useful would be for it to return the matched substring. Currently, the only way to do so is via match[0], but that's unintuitive and confusing
Thus, this PR changes
#to_s
to do just that. This is a breaking change, but I doubt many codebases actually use or rely on the old to_s.#inspect
still has the old behaviour.Resolves part of #13118