Fix can't resume a running fiber
#14128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in crystal-lang#14098 require that the fiber be associated to a thread once, instead of doing it on every swapcontext, yet enqueueing the fiber didn't do it while associating the fiber to a thread, which led to further enqueues to associate the fiber to any other thread, in which case a thread B was trying to resume a fiber that was still running on thread A (it didn't swap context, yet). closes crystal-lang#14124
|
Note: this is the theory. I didn't try it (yet), though I didn't get any bug on the |
straight-shoota
approved these changes
Dec 21, 2023
straight-shoota
added
kind:bug
topic:stdlib:concurrency
topic:multithreading
kind:regression
|
This has already been merged (I had issues with my linux linking an invalid executable when building the std specs only), but: I can reproduce the crash 100% on master and can't reproduce it anymore with this patch. CI may be less affected because there are less vCPU available than on our local laptops, so less parallelism to trigger the bug. |
|
Yeah, I had verified this patch locally as well. The error reproduced 0% while on master it was 100%. We're merging trivial regression fixes quickly in order to continue operations with a stable master. |
straight-shoota
changed the title
straight-shoota
changed the title
can't resume a running fiber
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #14098 require that the fiber be associated to a thread once, instead of doing it on every swapcontext, yet enqueueing the fiber didn't do it while associating the fiber to a thread, which led to further enqueues to associate the fiber to any other thread, in which case a thread B was trying to resume a fiber that was still running on thread A (it didn't swap context, yet).
closes #14124