Add Crystal::Repl#parse_and_interpret
#14138
Conversation
bcardiff
force-pushed
the
interpreter/lib-api
branch
from
e0340c6
to
502d131
Compare
| def runtime_type : Crystal::Type | ||
| if type.is_a?(Crystal::UnionType) | ||
| type_id = @pointer.as(Int32*).value | ||
| context.type_from_id(type_id) | ||
| else | ||
| type | ||
| end | ||
| end |
There was a problem hiding this comment.
chore: This feels like it should be introduced as a separate feature. It's not directly related to #parse_and_interpret. The specs should probably work fine without it, but we could also stack PRs.
There was a problem hiding this comment.
Yup. I aimed to that initially but then I remembered the one repl with prelude restriction and somehow push them together.
I'll send another PR for that.
In it we could use this to show type information as part of the repl: eg 1 :: Int32 <: (String | Int32) when instructed, but I'm not fully sure about the syntax. Or we can leave that usage for later also.
| record EvalSuccess, value : Value, warnings : WarningCollection | ||
| record EvalParserError, warnings : WarningCollection |
There was a problem hiding this comment.
question: Have you considered merging these two types as EvalResult? Their shape is similar.
There was a problem hiding this comment.
Sure. Using a nilable value would be enough
bcardiff
force-pushed
the
interpreter/lib-api
branch
from
502d131
to
80d5f67
Compare
|
I'm not sure if the CI failures are noise or actual failures. I am not familiar with latest changes on it and the missing symbol puzzles me. |
|
Either the spec should be moved under |
bcardiff
force-pushed
the
interpreter/lib-api
branch
from
9d0c90e
to
f31aefe
Compare
|
CI is happy. Thanks @HertzDevil |
straight-shoota
changed the title
Crystal::Repl#parse_and_interpret
This PR adds a
Crystal::Repl#parse_and_interpretmethod that is convenient to use the repl interpreter as library.The current interpreter api seems lower level . The repl is, as expected, tight to getting the input from stdin.
The added spec shows how the repl can be instantiated and consumed as a library.