Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codegen error when discarding is_a? or responds_to?'s result #14148

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix codegen error when discarding is_a? or responds_to?'s result #14148

merged 1 commit into from
Jan 4, 2024

Conversation

HertzDevil
Copy link
Contributor

Fixes #14113.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:codegen labels Dec 28, 2023
@straight-shoota straight-shoota added this to the 1.11.0 milestone Jan 3, 2024
@straight-shoota straight-shoota merged commit 2afc7c1 into crystal-lang:master Jan 4, 2024
56 checks passed
@HertzDevil HertzDevil deleted the bug/discarded-is_a branch January 4, 2024 18:38
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:codegen
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Discarded is_a? expression breaks codegen
2 participants
@HertzDevil @straight-shoota