Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple parameters and blocks for operators ending in = #14159

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Jan 2, 2024

Fixes #10397. Fixes #9963.

@straight-shoota
Copy link
Member

It might be useful to have specs that ensure calling these methods is also possible (parser + semantic). Do you want to add this here?

@HertzDevil HertzDevil changed the title Allow operators ending in = with multiple parameters Allow multiple parameters and blocks for operators ending in = Jan 2, 2024
@HertzDevil
Copy link
Contributor Author

I don't think this has anything to do with semantic specs. But there will be stdlib specs for this soon (delegate to be precise)

@straight-shoota straight-shoota modified the milestone: 1.11.0 Jan 2, 2024
@straight-shoota straight-shoota added this to the 1.12.0 milestone Jan 4, 2024
@straight-shoota straight-shoota merged commit b56c7d9 into crystal-lang:master Jan 10, 2024
56 checks passed
@HertzDevil HertzDevil deleted the bug/setter-operator branch January 11, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

>= and <= considered as setters, allow only one arguments, unlike > and < Can't declare method ==(*args)
2 participants