-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Etc/UTC
time zone identifier without tzdb
#14185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please seperate unrelated changes into independent PRs. The gitignore changes are a different issue.
The time location change requires updates to the API docs. At least on the directly affected methods. Possibly elsewhere like the class documentation.
a5637bf
to
fb7bdb6
Compare
what do you mean by api docs? the comment before the methods? changed |
ps: could #14174 be fixed? |
It's unclear what's even going on there, so I wouldn't know how it could possible be fixed. So far nobody has been able to reproduce this issue on their machine, so unless you can dig out more information, I fear everyone else is pretty much in the blind. |
Etc/UTC
time zone identifier without tzdb
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Co-authored-by: George Dietrich <george@dietrich.app>
@straight-shoota changed, I'm currently reading the specification now, |
src/time/location.cr
Outdated
# `UTC` is a special identifier, empty string represents a fallback mechanism. | ||
# `Etc/UTC` is technically a tzdb identifier which could potentially point to anything. | ||
# But we map it to `Location::UTC` directly for convenience which allows it to work | ||
# without a copy of the database. | ||
UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong indentation
fixed
…On Tue, Jan 9, 2024 at 8:36 PM Sijawusz Pur Rahnama < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/time/location.cr
<#14185 (comment)>
:
> + # `UTC` is a special identifier, empty string represents a fallback mechanism.
+ # `Etc/UTC` is technically a tzdb identifier which could potentially point to anything.
+ # But we map it to `Location::UTC` directly for convenience which allows it to work
+ # without a copy of the database.
+ UTC
Wrong indentation
—
Reply to this email directly, view it on GitHub
<#14185 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABWGTM3ZFY2HPJJ3GVTCTYNU2VBAVCNFSM6AAAAABBRCB6BOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJRGA3TANRUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Best Regards
femto
|
refers to this #14074,
Also I took the liberty of adding a few common things to .gitignore,
I can seperate that into a distinguish PR if you want