Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML::Reader: Disallow attributes containing null bytes #14193

Merged

Conversation

HertzDevil
Copy link
Contributor

These are the only remaining libxml2 functions which accept an arbitrary C string argument but aren't guarded by null checks yet.

@straight-shoota straight-shoota added this to the 1.12.0 milestone Jan 9, 2024
@straight-shoota straight-shoota merged commit 5bd7cb5 into crystal-lang:master Jan 12, 2024
57 checks passed
@HertzDevil HertzDevil deleted the bug/xml-attribute-null-byte branch January 26, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants