Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix OpenSSL error handling for EOF (support for OpenSSL 3.2) (#14169)" #14217

Merged

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jan 11, 2024

Reverts (most of) #14169.
I wasn't too confident about this patch and it appears it might negatively effect previously working versions of OpenSSL. So it's better to revert it and look for a proper solution to support OpenSSL 3.2.0.

See #14200 (comment)

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:crypto kind:regression Something that used to correctly work but no longer works status:reverted PR was reverted or reverts another one, and is not part of a milestone labels Jan 11, 2024
@straight-shoota straight-shoota self-assigned this Jan 11, 2024
@straight-shoota straight-shoota added this to the 1.11.1 milestone Jan 11, 2024
@straight-shoota straight-shoota merged commit 83ce2bc into crystal-lang:release/1.11 Jan 11, 2024
56 checks passed
@straight-shoota straight-shoota deleted the revert/13169 branch January 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works status:reverted PR was reverted or reverts another one, and is not part of a milestone topic:stdlib:crypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants