Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup for always use %p for pointers in Crystal::System.print_error #14221

Merged

Conversation

HertzDevil
Copy link
Contributor

Follow-up to #14186, which broke crash stack dumps

@HertzDevil HertzDevil added kind:bug topic:stdlib:runtime kind:regression Something that used to correctly work but no longer works labels Jan 11, 2024
@straight-shoota straight-shoota modified the milestones: 1.11.1, 1.12.0 Jan 11, 2024
@straight-shoota straight-shoota changed the title Fixup: Always use %p for pointers in Crystal::System.print_error Fix: Always use %p for pointers in Crystal::System.print_error Jan 13, 2024
@straight-shoota straight-shoota merged commit dba8038 into crystal-lang:master Jan 13, 2024
57 checks passed
@straight-shoota straight-shoota modified the milestones: 1.12.0, 1.11.2 Jan 18, 2024
straight-shoota pushed a commit to straight-shoota/crystal that referenced this pull request Jan 18, 2024
@straight-shoota straight-shoota changed the title Fix: Always use %p for pointers in Crystal::System.print_error Fixup for always use %p for pointers in Crystal::System.print_error Jan 18, 2024
@HertzDevil HertzDevil deleted the bug/print_error-crash branch January 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:stdlib:runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants