Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing cause parameter from IO::Error#initialize #14242

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fix missing cause parameter from IO::Error#initialize #14242

merged 2 commits into from
Jan 16, 2024

Conversation

straight-shoota
Copy link
Member

Resolves #14241

@straight-shoota straight-shoota added kind:bug topic:stdlib:files kind:regression Something that used to correctly work but no longer works labels Jan 15, 2024
@straight-shoota straight-shoota self-assigned this Jan 15, 2024
@straight-shoota straight-shoota changed the base branch from master to release/1.11 January 15, 2024 18:31
@beta-ziliani
Copy link
Member

Since this is public API, it'd be great to add tests so we don't fall again into it, WDYT?

beta-ziliani
beta-ziliani approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@beta-ziliani beta-ziliani added this to the 1.11.2 milestone Jan 16, 2024
@straight-shoota straight-shoota merged commit 261f46f into crystal-lang:release/1.11 Jan 16, 2024
56 checks passed
@straight-shoota straight-shoota deleted the fix/io-error-cause branch January 16, 2024 18:39
@straight-shoota straight-shoota mentioned this pull request Jan 16, 2024
Closed
@Porkepix Porkepix mentioned this pull request Jan 18, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:stdlib:files
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.

IO::Error no parameter named 'cause'
2 participants
@straight-shoota @beta-ziliani