Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BigRational#%, #tdiv, #remainder #14306

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add BigRational#%, #tdiv, #remainder #14306

merged 1 commit into from
Feb 21, 2024

Conversation

HertzDevil
Copy link
Contributor

These accept both Int and BigRational as arguments.

For those arguments, the PR also overrides Number#// with a more uniform implementation.

@straight-shoota straight-shoota added this to the 1.12.0 milestone Feb 19, 2024
@straight-shoota straight-shoota merged commit 9866e50 into crystal-lang:master Feb 21, 2024
56 of 57 checks passed
@HertzDevil HertzDevil deleted the feature/bigrational-div branch February 21, 2024 12:11
@BrewTestBot BrewTestBot mentioned this pull request Apr 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:numeric
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota