Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't copy DLL to output directory if file already exists #14315

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Don't copy DLL to output directory if file already exists #14315

merged 1 commit into from
Feb 22, 2024

Conversation

HertzDevil
Copy link
Contributor

Fixes #14314.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain topic:compiler:codegen labels Feb 21, 2024
@straight-shoota straight-shoota added this to the 1.12.0 milestone Feb 21, 2024
@straight-shoota straight-shoota merged commit 0045aa5 into crystal-lang:master Feb 22, 2024
57 checks passed
@HertzDevil HertzDevil deleted the bug/windows-dll-copy branch February 22, 2024 16:08
@BrewTestBot BrewTestBot mentioned this pull request Apr 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain topic:compiler:codegen
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Permission denied opening libiconv.dll
2 participants
@HertzDevil @straight-shoota