Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NaN comparisons in the interpreter #14441

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Handle NaN comparisons in the interpreter #14441

merged 2 commits into from
Apr 8, 2024

Conversation

HertzDevil
Copy link
Contributor

Fixes #13909.

Note that #<=> is never a primitive, so the interpreter bytecode doesn't really have to define instructions doing that.

@straight-shoota straight-shoota added this to the 1.12.0 milestone Apr 6, 2024
@straight-shoota straight-shoota merged commit 8f1d45a into crystal-lang:master Apr 8, 2024
58 checks passed
@HertzDevil HertzDevil deleted the bug/interpreter-nan-cmp branch April 8, 2024 13:16
@BrewTestBot BrewTestBot mentioned this pull request Apr 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler:interpreter topic:stdlib:numeric
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Float64::NAN > 0 in the interpreter
2 participants
@HertzDevil @straight-shoota