Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never raise IndexError in #[]?(Range) #14444

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

HertzDevil
Copy link
Contributor

Fixes #14340.

@straight-shoota
Copy link
Member

I'm pushing this to 1.13 because 1.12.0 is just around the corner. I don't expect any realistic issues, but there's a slight chance that this change could break some code which expected an exception being raised.

@straight-shoota straight-shoota merged commit 1243868 into crystal-lang:master Apr 12, 2024
58 checks passed
@HertzDevil HertzDevil deleted the bug/index-range-nil branch April 15, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some #[]?(Range) methods can still raise IndexError
2 participants