Allow parsing cookies with space in the value #14455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Apr 8, 2024
anton7c3
force-pushed
the
master
branch
2 times, most recently
from
eeb056a
to
ebce743
Compare
Sija
approved these changes
Apr 8, 2024
|
Looks good to me and fixes the current issue I'm seeing (#14435) |
bararchy
approved these changes
Apr 8, 2024
hovsater
reviewed
Apr 8, 2024
anton7c3
force-pushed
the
master
branch
3 times, most recently
from
c748b0d
to
912f1c1
Compare
Sija
reviewed
Apr 15, 2024
anton7c3
force-pushed
the
master
branch
2 times, most recently
from
dac7efe
to
1c91eaa
Compare
Sija
approved these changes
May 16, 2024
straight-shoota
approved these changes
May 20, 2024
bararchy
approved these changes
May 29, 2024
beta-ziliani
approved these changes
May 29, 2024
ysbaddaden
reviewed
May 30, 2024
Fixes crystal-lang#14435. Move parse_set_cookie example to the correct location.
straight-shoota
approved these changes
May 31, 2024
ysbaddaden
approved these changes
Jun 25, 2024
straight-shoota
changed the title
1 task
akadusei
added a commit
to akadusei/lucky
that referenced
this pull request
Aug 12, 2024
```
Failures:
1) Lucky::CookieJar raises a nicer error for invalid cookie values
Failure/Error: expect_raises(Lucky::InvalidCookieValueError, "Cookie value for 'cookie' is invalid") do
Expected Lucky::InvalidCookieValueError but nothing was raised
Error: # spec/lucky/cookies/cookie_jar_spec.cr:41
```
Crystal v1.13 accepts space in cookie values as valid.
See <crystal-lang/crystal#14455>.
5 tasks
jwoertink
pushed a commit
to luckyframework/lucky
that referenced
this pull request
Aug 12, 2024
* Fix invalid query string for array params
* Add spec expectation
* Add check for correctness of values returned from array query params
* Fix failed specs in Crystal v1.13
```
Failures:
1) Lucky::CookieJar raises a nicer error for invalid cookie values
Failure/Error: expect_raises(Lucky::InvalidCookieValueError, "Cookie value for 'cookie' is invalid") do
Expected Lucky::InvalidCookieValueError but nothing was raised
Error: # spec/lucky/cookies/cookie_jar_spec.cr:41
```
Crystal v1.13 accepts space in cookie values as valid.
See <crystal-lang/crystal#14455>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14435.
Move parse_set_cookie example to the correct location.