Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AST node methods for macro-related nodes #14492

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Add AST node methods for macro-related nodes #14492

merged 3 commits into from
Apr 19, 2024

Conversation

HertzDevil
Copy link
Contributor

Resolves part of #3274.

MacroVerbatim has no new methods, since UnaryExpression covers everything already.

straight-shoota
straight-shoota reviewed Apr 15, 2024
View reviewed changes
spec/compiler/macro/macro_methods_spec.cr Outdated Show resolved Hide resolved
src/compiler/crystal/macros.cr Outdated Show resolved Hide resolved
src/compiler/crystal/macros.cr Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 1.13.0 milestone Apr 18, 2024
@straight-shoota straight-shoota merged commit 3c76662 into crystal-lang:master Apr 19, 2024
61 checks passed
@HertzDevil HertzDevil deleted the feature/macro-macro-methods branch April 19, 2024 10:18
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees

@HertzDevil HertzDevil

Labels
kind:feature topic:stdlib:macros
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HertzDevil @Sija @straight-shoota