Make File.readable? and .writable? follow symlinks on Windows
#14514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
platform:windows
Sija
reviewed
Apr 21, 2024
| private def self.accessible?(path, *, check_writable) | ||
| private def self.accessible?(path, *, check_writable, follow_symlinks) | ||
| if follow_symlinks | ||
| path = realpath?(path) || return false |
There was a problem hiding this comment.
Suggestion: more idiomatic version:
Suggested change
| path = realpath?(path) || return false | |
| return false unless path = realpath?(path) |
There was a problem hiding this comment.
@Sija I disagree on being more idiomatic. IMO it makes a lot more sense to focus on the assignment and an escape condition. A trailing assignment is very easy to overlook.
straight-shoota
approved these changes
Apr 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the behavior on Unix-like systems. The ability to opt out could be reintroduced as part of #13291.
Note that
File.readable?can never return false for an existing file on Windows since the method doesn't respect ACLs, but it does return false for a non-existing file. Hence, this method is now entirely equivalent toFile.exists?.