Extract #system_read
and #system_write
for FileDescriptor
and Socket
#14626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, individual system implementations of
System::FileDescriptor
andSystem::Socket
implementIO#unbuffered_read
andIO#unbuffered_write
directly. This patch pulls the implementation up to be shared between all platforms, and instead delegates to#system_read
and#system_write
.#unbuffered_write
is now responsible for ensuring that the entire content of the slice is written, callingsystem_write
multiple times if necessary. (Looks like this wasn't implemented correctly inSocket
on Windows before)This is a simplification step in preparation for a bigger refactoring which will delegate
#system_read
and#system_write
to the event loop (crystal-lang/rfcs#7).