Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL: don't change default cipher suites #14655

Merged
merged 1 commit into from
Jun 4, 2024
Merged

OpenSSL: don't change default cipher suites #14655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/openssl/ssl/context.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,13 @@ abstract class OpenSSL::SSL::Context
# context = OpenSSL::SSL::Context::Client.new
# context.add_options(OpenSSL::SSL::Options::NO_SSL_V2 | OpenSSL::SSL::Options::NO_SSL_V3)
# ```
#
# It uses `CIPHERS_OLD` compatibility level by default.
def initialize(method : LibSSL::SSLMethod = Context.default_method)
super(method)

self.verify_mode = OpenSSL::SSL::VerifyMode::PEER
{% if LibSSL.has_method?(:x509_verify_param_lookup) %}
self.default_verify_param = "ssl_server"
{% end %}

self.ciphers = CIPHERS_OLD
end

# Returns a new TLS client context with only the given method set.
Expand Down Expand Up @@ -128,8 +124,6 @@ abstract class OpenSSL::SSL::Context
# context = OpenSSL::SSL::Context::Server.new
# context.add_options(OpenSSL::SSL::Options::NO_SSL_V2 | OpenSSL::SSL::Options::NO_SSL_V3)
# ```
#
# It uses `CIPHERS_INTERMEDIATE` compatibility level by default.
def initialize(method : LibSSL::SSLMethod = Context.default_method)
super(method)

Expand All @@ -138,8 +132,6 @@ abstract class OpenSSL::SSL::Context
{% end %}

set_tmp_ecdh_key(curve: LibCrypto::NID_X9_62_prime256v1)

self.ciphers = CIPHERS_INTERMEDIATE
end

# Returns a new TLS server context with only the given method set.
Expand Down
Loading