Fix: use SOCK_CLOEXEC with FD_CLOEXEC fallback
#14672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmonizes the implementations between Darwin and other POSIX platforms. Now we try to use `SOCK_CLOEXEC` in the `socket`, `socketpair` and `accept4` syscalls. The `accept4` syscall is non-standard but widely available: Linux, all supported BSD, except for Darwin (obviously). When `SOCK_CLOEXEC` isn't available, we don't delay to `Socket#initialize_handle` anymore to set `FD_CLOEXEC` for Darwin only, but immediately call `fcntl` to set it after the above syscalls. The patch also fixes an issue where TCP and UNIX client sockets didn't have `FD_CLOEXEC` on all POSIX platforms... except for Darwin.
|
Follow up: we'll want to prevent Prior art: Go is doing that. |
|
|
No need to check for SOCK_CLOEXEC since there is no point in implementing the accept4 syscall without this feature.
ysbaddaden
added a commit
to ysbaddaden/crystal
that referenced
this pull request
Jun 7, 2024
straight-shoota
approved these changes
Jun 13, 2024
beta-ziliani
approved these changes
Jun 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harmonizes the implementations between Darwin and other POSIX platforms for the "close on exec" behavior.
When
SOCK_CLOEXECis available, we always use it in thesocket,socketpairandaccept4syscalls. WhenSOCK_CLOEXECisn't available, we don't delay toSocket#initialize_handleanymore to setFD_CLOEXECfor Darwin only, but immediately callfcntlto set it after the above syscalls.The
accept4syscall is non-standard but widely available: Linux, all supported BSD, except for Darwin (obviously).The patch also fixes an issue where TCP and UNIX client sockets didn't have
FD_CLOEXECon POSIX platforms... except for Darwin.closes #14650