Fix: don't hardcode alpn protocol byte size (OpenSSL) #14769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason OpenSSL used to negotiate the protocol by itself, without invoking the select callback, or maybe didn't respect the total bytesize when processing the alpn string. That changed in the 3.0.14 and other bugfix releases of OpenSSL, which exposed the bug.
|
@beta-ziliani I'm just sweeping after my bugs: It only took 8 years to notice. |
straight-shoota
pushed a commit
that referenced
this pull request
Jul 2, 2024
For some reason OpenSSL used to negotiate the protocol by itself, without invoking the select callback, or maybe it didn't respect the total bytesize when processing the alpn string. That changed in the 3.0.14 and other bugfix releases of OpenSSL, which exposed the bug.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason OpenSSL used to negotiate the protocol by itself, without invoking the select callback, or maybe didn't respect the total bytesize when processing the alpn string.
That changed in the 3.0.14 and other bugfix releases of OpenSSL, which exposed the bug.
EDIT: the best proof is the fixed OpenSSL 3.0 test suite on CI ✔️