Add spec for Compress::Gzip::Writer
with extra
#14788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a spec to ensure that writing an
extra
header field works.Follow-up to #14550
Note the generated gzip data is not binary identical to the
test.gz
fixture, so we cannot directly compare the written gzip data.Instead, the spec reads the data and verifies it has the same content as
test.gz
.I believe the difference is because
Compress::Gzip::Writer
does not include a CRC for the header data (ref C implementation).