Support LLVM 19.1 #14842
Draft
Support LLVM 19.1 #14842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Aug 5, 2024
ysbaddaden
reviewed
Aug 19, 2024
| LibLLVM.di_builder_insert_declare_at_end(self, storage, var_info, expr, dl, block) | ||
| {% else %} | ||
| LibLLVM.di_builder_insert_declare_record_at_end(self, storage, var_info, expr, dl, block) | ||
| {% end %} |
There was a problem hiding this comment.
Oh my, we're returning a raw Void* from LLVM here, which may be a LibLLVM::ValueRef or a LibLLVM::DbgRecordRef now 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14840. Tested on Debian using
1:19.1.0~++20240730073008+404746b9f21b-1~exp1~20240730073118.4.The return type of
LLVM::DIBuilder#insert_declare_at_endnow differs betweenLibLLVM::ValueRefandLibLLVM::DbgRecordRefdepending on whether LLVM is new enough (both are typedefs toVoid*), although this return value is never used in the compiler itself.