Fix ReferenceStorage(T)
atomic if T
has no inner pointers
#14845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the fix in #14730 made all
ReferenceStorage
objects non-atomic;Crystal::ReferenceStorageType#reference_type
returns a reference type, whose#has_inner_pointers?
always returns true since the reference itself is a pointer:This PR fixes that again: (note the presence of
atomic=1
on the first line)