Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IO::Buffered#buffer_size= idempotent #14855

Merged

Conversation

jgaskins
Copy link
Contributor

The purpose of raising an exception here is to prevent the caller from doing something unsafe. Changing the value is unsafe, but setting buffer_size to the same value is a safe operation.

Fixes #11270

@straight-shoota straight-shoota added this to the 1.14.0 milestone Sep 3, 2024
@straight-shoota straight-shoota merged commit 1055af2 into crystal-lang:master Sep 4, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ergonomics of changing IO::Buffered buffer_size
3 participants