Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explicitly clear deleted Hash::Entry #14862

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

HertzDevil
Copy link
Contributor

Fixes #14859

@straight-shoota straight-shoota added this to the 1.14.0 milestone Aug 2, 2024
@beta-ziliani
Copy link
Member

Note: The failing window test is unrelated

@straight-shoota straight-shoota changed the title Always clear deleted keys and values in Hash Fix explicitly clear deleted Hash::Entry Aug 5, 2024
@straight-shoota straight-shoota merged commit 43e4f1d into crystal-lang:master Aug 5, 2024
60 of 61 checks passed
@HertzDevil HertzDevil deleted the perf/hash-delete branch August 5, 2024 14:46
@straight-shoota straight-shoota modified the milestones: 1.14.0, 1.13.2 Aug 15, 2024
@crysbot
Copy link

crysbot commented Aug 21, 2024

This pull request has been mentioned on Crystal Forum. There might be relevant details there:

https://forum.crystal-lang.org/t/crystal-1-13-2-is-released/7110/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Hash do not clean references to objects in --release mode
6 participants