Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle empty string in String#to_f(whitespace: false) #14902

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

Blacksmoke16
Copy link
Member

Resolves #14901

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric labels Aug 14, 2024
src/string.cr Outdated Show resolved Hide resolved
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@straight-shoota straight-shoota added this to the 1.14.0 milestone Aug 14, 2024
@straight-shoota straight-shoota changed the title Handle String#to_f whitespace: false with empty string Fix handle empty string in String#to_f(whitespace: false) Aug 15, 2024
@straight-shoota straight-shoota merged commit 3bf3410 into crystal-lang:master Aug 16, 2024
65 checks passed
@Blacksmoke16 Blacksmoke16 deleted the empty-string-to-f branch January 9, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number.new causes IndexError with blank value and whitespace: false
4 participants