Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-blocking File#read and #write on Windows #14940

Conversation

HertzDevil
Copy link
Contributor

Extracted from #14321.

The specs use opened files in a more or less synchronous manner, merely ensuring passing blocking: false to File.open do not break. Additional specs that actually exercise concurrency are welcome.

@straight-shoota straight-shoota added this to the 1.14.0 milestone Aug 25, 2024
@straight-shoota straight-shoota merged commit c015ff6 into crystal-lang:master Sep 2, 2024
65 checks passed
@HertzDevil HertzDevil deleted the feature/windows-file-read-write-non-blocking branch September 2, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants