Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close some dangling sockets in specs #15163

Merged

Conversation

HertzDevil
Copy link
Contributor

These appear to be causing intermittent CI failures, especially on Windows (e.g. https://github.com/crystal-lang/crystal/actions/runs/11031590842/job/30639450164).

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:networking labels Nov 6, 2024
spec/std/socket/socket_spec.cr Outdated Show resolved Hide resolved
spec/std/socket/udp_socket_spec.cr Outdated Show resolved Hide resolved
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
@straight-shoota straight-shoota added this to the 1.15.0 milestone Nov 6, 2024
@straight-shoota straight-shoota merged commit eabc15d into crystal-lang:master Nov 7, 2024
69 checks passed
@HertzDevil HertzDevil deleted the bug/socket-spec-dangling branch November 8, 2024 03:19
CTC97 pushed a commit to CTC97/crystal that referenced this pull request Nov 9, 2024
These appear to be causing intermittent CI failures, especially on Windows (e.g. https://github.com/crystal-lang/crystal/actions/runs/11031590842/job/30639450164).

Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants