Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Process::Status#exit_code? #15247

Conversation

straight-shoota
Copy link
Member

Adds a new method #exit_code? which returns nil if no value is available as proposed in #15228.

This provides an alternative to #exit_code which raises in this case since #15241.

@straight-shoota straight-shoota added this to the 1.15.0 milestone Dec 6, 2024
@straight-shoota straight-shoota merged commit 655b8a5 into crystal-lang:master Dec 7, 2024
69 checks passed
@straight-shoota straight-shoota deleted the feat/add-process_status-exit_code-nilable branch December 7, 2024 18:55
straight-shoota added a commit that referenced this pull request Dec 10, 2024
Use the new non-raising variant `#exit_code?` (introduced in #15247) where possible over `#exit_code` which raises since #15241. The code can also be simplified in some cases, removing unnecessary calls to `Status#normal_exit?`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants