Allow to check Hash subset in ContainExpectation #7498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j8r
reviewed
Mar 3, 2019
| expected_value = @expected_value | ||
| if expected_value.is_a?(Hash) && actual_value.is_a?(Hash) | ||
| expected_value.all? do |key, value| | ||
| actual_value[key]? == value |
There was a problem hiding this comment.
This behavior isn't consistent with how includes? works. I don't know what problem it's supposed to solve.
There was a problem hiding this comment.
It was discussed at length at Gitter as well as in several comments in before-mentioned issue. IMHO giving downvotes before you understand the problem at hand doesn't make much sense and if anything it shows an ill-will you hold for some reason...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7497