Remove Slice#pointer #7581
Merged
Remove Slice#pointer #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Mar 23, 2019
Sija
reviewed
Mar 24, 2019
Maroo-b
force-pushed
the
7004_remove_slice_pointer_method
branch
3 times, most recently
from
9ee2f84
to
5d2d998
Compare
straight-shoota
approved these changes
Apr 2, 2019
Issue: crystal-lang#7004 Slice#pointer caused confusion and it used mainly for verification.
Maroo-b
force-pushed
the
7004_remove_slice_pointer_method
branch
from
5d2d998
to
0337409
Compare
sdogruyol
approved these changes
May 30, 2019
asterite
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7004
As discussed with @straight-shoota and @asterite
Slice#pointeris a confusing method and it should be removed.The code was refactored to keep the verification logic in
Slicemainly for copy methods.I was thinking if we should add a deprecation warning or just mention this as a breaking change in case someone is using
Slice#pointer.