Let IO#copy return UInt64 #7660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated thing: it can be a instance methods, and add the annotation |
|
@j8r An instance method would be weird. Does it copy the receiver to the argument or is it the other way around? We'd need to go with |
straight-shoota
approved these changes
Apr 9, 2019
|
We could actually have copy_to and copy_from but it's a separate discussion |
RX14
approved these changes
Apr 25, 2019
RX14
added
breaking-change
kind:bug
|
Does this PR fixes #3209 as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7659
IO.copyshouldn't overflow. Plus the return value isn't normally used. But when it is, it's better if it has the correct value, accounting for large uploads/copies.