Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format: don't produce unnecessary newline before named args following heredoc #7695

Merged
merged 1 commit into from
May 2, 2019
Merged

Format: don't produce unnecessary newline before named args following heredoc #7695

merged 1 commit into from
May 2, 2019

Conversation

makenowjust
Copy link
Contributor

Fixed #7684

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Apr 24, 2019
@straight-shoota
Copy link
Member

@makenowjust needs a rebase

@makenowjust makenowjust force-pushed the fix/format-heredoc-named-args branch from b61f523 to 492244f Compare April 27, 2019 01:29
@asterite asterite added this to the 0.29.0 milestone May 2, 2019
@asterite asterite merged commit b22c386 into crystal-lang:master May 2, 2019
@makenowjust makenowjust deleted the fix/format-heredoc-named-args branch May 3, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.

Formatter is not satisfied with formatting arguments with heredoc only once
3 participants
@makenowjust @straight-shoota @asterite