validate xml element names #7965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Jul 15, 2019
asterite
added
kind:feature
topic:stdlib:serialization
kind:bug
asterite
reviewed
Jul 15, 2019
ysbaddaden
approved these changes
Jul 15, 2019
bcardiff
reviewed
Jul 15, 2019
bcardiff
approved these changes
Jul 15, 2019
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
* validate xml element names * validate name and prefix separately * keep things DRY * only check for null bytes once * pass unsafe name to StartElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
LibXML.xmlValidateNameValueto validate the provided name when usingXML::Builderto build elements.Fixes #7963
Fixes Blacksmoke16/oq#9