Fix incorrect Int#% overflow #7980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
oprypin
reviewed
Jul 21, 2019
Doing `(x ^ y) >= 0` doesn't work well for determining whether `x` and `y` have the same sign when their types are not the same (for example `Int32` and `Int64`).
bcardiff
approved these changes
Jul 25, 2019
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
Doing `(x ^ y) >= 0` doesn't work well for determining whether `x` and `y` have the same sign when their types are not the same (for example `Int32` and `Int64`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7979
Doing
(x ^ y) >= 0doesn't work well for determining whetherxandyhave the same sign when their types are not the same (for exampleInt32andInt64).