Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Number#humanize digits #8027

Conversation

straight-shoota
Copy link
Member

The calculation was incorrect for powers of 10.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric labels Aug 1, 2019
@straight-shoota straight-shoota merged commit 6c81265 into crystal-lang:master Aug 2, 2019
@straight-shoota straight-shoota added this to the 0.31.0 milestone Aug 2, 2019
@straight-shoota straight-shoota deleted the fix/number-humanize-digits branch August 2, 2019 11:05
@bcardiff bcardiff modified the milestones: 0.31.0, 0.30.1 Aug 8, 2019
bcardiff pushed a commit that referenced this pull request Aug 8, 2019
dnamsons pushed a commit to dnamsons/crystal that referenced this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants