Compiler: fix crash when formatting syntax error inside macro

[asterite]

Fixes #8038

Also improves the code a bit.

💭 I wonder whether we should make min, max, etc., always be nilable... that way you would always remember to handle the empty case, and in case you are sure you aren't dealing with an empty collection you can always stick a not_nil! there.

[bcardiff]

Given that an enumerable can be empty as a value, it could make sense to min/max be nilable, and have min!/max! as an unsafe “trust-me-is-not-empty” version. But on other hand the operation itself is not defined for empty sets, so is reasonable to have a non trivial precondition.

[oprypin]

I wonder whether we should make min, max, etc., always be nilable

That's the kind of thing that causes a knee-jerk negative reaction for me.
But then if I actually think about it, it totally is an improvement.

always remember to handle the empty case

[bcardiff]

The linux32 CI is failing constantly this time. Maybe #8065 could help

[j8r]

Since this part is refactored, we can simplify it by avoiding using a regex:

line.each_char_with_index do |char, index|
  return index if char != ' '
end
0

[asterite]

No, \s matches tab, spaces, maybe also unicode space, I don't know.

This code runs once when the compiler finds an error, optimizing here has no impact at all. Maybe it's 5ms faster, the user can't possibly tell.

I also prefer avoiding changing code if it's not broken.

[j8r]

Ho, there is char.ascii_whitespace?

But that's basically what's done here, the code is already changed.