Refactor class var initialization #8091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
approved these changes
Aug 17, 2019
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
* Refactor class var initialization * Simple class vars are not eager initialized anymore * Simplify code of class var codegen: pass around the MetaTypeVar as much as possible instead of its members * Cache initialization of simple class vars
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big refactor of the class var codegen and it actually revert changes from #8067 and obtain the same results with a different approach.
Now the class var initializer is decided to be "simple" after trying to generate the code to initialize it. This cover more cases like calls to functions with just a literal in the body, and avoids unnecessary initialization flags and reader methods whenever possible.