Delay releasing of fiber stack in multithread mode #8138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue found by @asterite in multithread mode (
-Dpreview_mt
)For example, this code currently fails with really random and nasty errors:
This is because the fiber stacks are reused but in multithread mode this reuse can happen before the current fiber actually finishes using it.
I didn't add a spec because I don't know how to consistently reproduce it with an example that doesn't involve 1M fibers :)