Remove the event loop fiber #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fiber when there are no more runnable fibers in the queue.
|
Does this have a performance bump? |
|
@wontruefree yes, I've seen that thread and yes, it should have a performance improvement although don't expect it to be really big. It just removes an extra context switch made every time there are no more runnable fibers and the runtime holds on the event loop for something to happen. |
bcardiff
approved these changes
Sep 10, 2019
sdogruyol
approved these changes
Sep 11, 2019
|
For the curious and @wontruefree this might be a pointer of the performance boost 👍 https://twitter.com/sdogruyol/status/1171814376212508672 |
|
I thought there might be a performance boost. I was just curious if you had measured it since you removed some code. |
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
…fiber when there are no more runnable fibers in the queue. (crystal-lang#8173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the commit 284fb1e there is actually no need to have a dedicated fiber to run the event loop. This is because now the event loop callbacks do not resume fibers directly and also it's not executing in endless non-returning mode.
With these changes the event loop is executed by any fiber that calls for a
rescheduleand there are no more fibers in the queue. This removes an extra context switch in those cases and provide a small but noticeable performance improvement for IO intensive apps.