Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constant for websocket protocol GUID string #8339

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Use constant for websocket protocol GUID string #8339

merged 2 commits into from
Oct 29, 2019

Conversation

vlazar
Copy link
Contributor

@vlazar vlazar commented Oct 16, 2019

I think it would make sense to extract this magic WebSocket protocol string to a constant for clarification.

@RX14 RX14 added this to the 0.32.0 milestone Oct 29, 2019
@RX14 RX14 merged commit eee8e95 into crystal-lang:master Oct 29, 2019
@asterite asterite mentioned this pull request Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib:networking
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vlazar @Sija @RX14