Return nil (and don't raise) when "Content-Type" header is an empty string. #8464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
added
kind:bug
|
Can we get a spec (and a PR description that describes what and not how?) |
|
@bcardiff done! |
bcardiff
approved these changes
Nov 12, 2019
Sija
changed the title
String#presence in HTTP::Client::Response#mime_type
straight-shoota
approved these changes
Nov 12, 2019
|
@bcardiff did he get the bonus points for using string presence? ;) |
|
Of course! |
|
should the be the default behavior or |
|
@wontruefree According to RFC 7230 empty header values are legal, so we should honor that and don't confuse it with an absent header. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
HTTP::Client::Response#mime_typeto returnnil(and not raise) whenContent-Typeheader is an empty string.As per #8398 (comment)
Fixes #8398