Add String#center method #8557
Merged
Add String#center method #8557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkthorne
reviewed
Dec 5, 2019
src/string.cr
Outdated
|
|
||
| unless left | ||
| buffer.copy_from(to_unsafe, bytesize) | ||
| Intrinsics.memcpy(buffer.as(Void*), to_unsafe.as(Void*), bytesize, false) |
There was a problem hiding this comment.
I think you might be able to use Pointer.copy_from
Suggested change
| Intrinsics.memcpy(buffer.as(Void*), to_unsafe.as(Void*), bytesize, false) | |
| buffer.copy_from(to_unsafe, bytesize) |
There was a problem hiding this comment.
I see now this is diff noise so this might be outside the scope of this PR.
There was a problem hiding this comment.
Is this "better" than memcpy ?
There was a problem hiding this comment.
It's the same as memcpy, but shorter.
It's fine to leave this as-is for this PR.
|
This continues the previous PR #3924 (stalled). |
RX14
reviewed
Dec 7, 2019
src/string.cr
Outdated
| when .> 0 | ||
| leftpadding, rightpadding = padding, 0 | ||
| else | ||
| leftpadding = padding >> 1 |
There was a problem hiding this comment.
// 2, please
there's no need for manual pinhole optimizations the compiler is perfectly capable of.
src/string.cr
Outdated
|
|
||
| unless left | ||
| buffer.copy_from(to_unsafe, bytesize) | ||
| Intrinsics.memcpy(buffer.as(Void*), to_unsafe.as(Void*), bytesize, false) |
There was a problem hiding this comment.
It's the same as memcpy, but shorter.
It's fine to leave this as-is for this PR.
RX14
approved these changes
Dec 7, 2019
|
Thank you! |
bcardiff
approved these changes
Dec 9, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String#center(width, char)returns a new string of lengthwidthwith original string centered, and padded withchar(default = space)