Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits in kernel.cr #8606

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Edits in kernel.cr #8606

merged 1 commit into from
Dec 26, 2019

Conversation

fxn
Copy link
Contributor

@fxn fxn commented Dec 21, 2019

Minor details I saw while reading source code in kernel.cr.

  • "consists from" should be "consists of".
  • "use" → "uses" for consistency with the rest of the list items.
  • "modifies" is not correct in "The flags modifies". Leveraged the edit to reword a bit.
  • Removes periods in "Precision for..." sentences for consistency with similar surrounding ones.

The other two are clear.

@RX14 RX14 added the kind:docs label Dec 22, 2019
straight-shoota
straight-shoota reviewed Dec 25, 2019
View reviewed changes
src/kernel.cr Outdated
@@ -320,24 +321,24 @@ end
# sprintf "%20.8b", -11 # => " -1011"
# ```
#
# Precision for `e` is number of digits after the decimal point.
# Precision for `e` is number of digits after the decimal point
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather add full stops where they're missing, instead of removing them here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@straight-shoota great. I ended up adding colons, which are used commonly to introduce code examples, and are also present in the code base.

@asterite asterite added this to the 0.33.0 milestone Dec 26, 2019
@asterite asterite merged commit fd32284 into crystal-lang:master Dec 26, 2019
@fxn fxn deleted the edits-kernel.cr branch December 26, 2019 13:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota left review comments

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:docs topic:stdlib
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fxn @straight-shoota @RX14 @asterite @bcardiff