Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: propagate visibility to macro expansions in all cases #8762

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Compiler: propagate visibility to macro expansions in all cases #8762

merged 1 commit into from
Feb 8, 2020

Conversation

asterite
Copy link
Member

@asterite asterite commented Feb 7, 2020

Fixes #8715

@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Feb 7, 2020
@asterite
Copy link
Member Author

asterite commented Feb 7, 2020

Feel free to merge this and any of my PRs. I won't because I don't know if these should go into 0.33.0 or where.

@asterite asterite added this to the 0.33.0 milestone Feb 8, 2020
@asterite asterite merged commit e9a68df into master Feb 8, 2020
@asterite asterite deleted the bug/private-not-propagated branch February 8, 2020 11:55
@bcardiff bcardiff mentioned this pull request Feb 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

@jhass jhass jhass approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.

private record is allowed but doesn't make the struct private
3 participants
@asterite @jhass @bcardiff