Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise when calling #size on an open range #8829

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Raise when calling #size on an open range #8829

merged 1 commit into from
Feb 21, 2020

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Feb 21, 2020

Closes #8151

@RX14 RX14 merged commit 7d63d37 into crystal-lang:master Feb 21, 2020
@RX14 RX14 added this to the 0.34.0 milestone Feb 21, 2020
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:collection labels Feb 21, 2020
@Sija
Copy link
Contributor Author

Sija commented Feb 21, 2020

That's a breaking change, mind you.

@RX14
Copy link
Contributor

RX14 commented Feb 23, 2020

I don't think that any program which worked before will fail to work now.

@straight-shoota straight-shoota mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

@RX14 RX14 RX14 approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:collection
Projects
None yet
Milestone
0.34.0
Development

Successfully merging this pull request may close these issues.

Calling Range(_, Nil)#size hangs in runtime
4 participants
@Sija @RX14 @asterite @bcardiff