Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Regex#hash and Regex::MatchData#hash #8986

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Add missing Regex#hash and Regex::MatchData#hash #8986

merged 1 commit into from
Apr 2, 2020

Conversation

makenowjust
Copy link
Contributor

When a class has custom ==, it should define hash for its custom equality.
However Regex and Regex::MatchData is missing its own hash method.

This PR adds hash method for them and also adds spec for these. Thank you.

@bcardiff bcardiff added this to the 0.34.0 milestone Apr 2, 2020
@bcardiff bcardiff merged commit 317d916 into crystal-lang:master Apr 2, 2020
@makenowjust makenowjust deleted the fix/regex/hash branch April 2, 2020 15:36
carlhoerberg pushed a commit to carlhoerberg/crystal that referenced this pull request Apr 29, 2020
@makenowjust @carlhoerberg
Add missing Regex#hash and Regex::MatchData#hash (crystal-lang#8986)
8214d3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:text
Projects
None yet
Milestone
0.34.0
Development

Successfully merging this pull request may close these issues.
4 participants
@makenowjust @straight-shoota @RX14 @bcardiff